Mercurial > jhg
annotate src/org/tmatesoft/hg/repo/HgManifest.java @ 266:0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
| author | Artem Tikhomirov <tikhomirov.artem@gmail.com> | 
|---|---|
| date | Fri, 19 Aug 2011 04:59:32 +0200 | 
| parents | 6bb5e7ed051a | 
| children | ec921ef0628e | 
| rev | line source | 
|---|---|
| 
13
 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
2 
diff
changeset
 | 
1 /* | 
| 
74
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
2 * Copyright (c) 2010-2011 TMate Software Ltd | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
3 * | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
4 * This program is free software; you can redistribute it and/or modify | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
5 * it under the terms of the GNU General Public License as published by | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
6 * the Free Software Foundation; version 2 of the License. | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
7 * | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
8 * This program is distributed in the hope that it will be useful, | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
9 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
11 * GNU General Public License for more details. | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
12 * | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
13 * For information on how to redistribute this software under | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
14 * the terms of a license other than GNU General Public License | 
| 
102
 
a3a2e5deb320
Updated contact address to support@hg4j.com
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
77 
diff
changeset
 | 
15 * contact TMate Software at support@hg4j.com | 
| 
2
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
16 */ | 
| 
74
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
17 package org.tmatesoft.hg.repo; | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
18 | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
19 import static org.tmatesoft.hg.repo.HgRepository.TIP; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
20 | 
| 
232
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
21 import java.io.ByteArrayOutputStream; | 
| 
157
 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
diff
changeset
 | 
22 import java.io.IOException; | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
23 import java.util.ArrayList; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
24 import java.util.Arrays; | 
| 
157
 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
diff
changeset
 | 
25 | 
| 
 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
diff
changeset
 | 
26 import org.tmatesoft.hg.core.HgBadStateException; | 
| 
74
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
27 import org.tmatesoft.hg.core.Nodeid; | 
| 
157
 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
diff
changeset
 | 
28 import org.tmatesoft.hg.internal.DataAccess; | 
| 
266
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
29 import org.tmatesoft.hg.internal.DigestHelper; | 
| 
232
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
30 import org.tmatesoft.hg.internal.Experimental; | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
31 import org.tmatesoft.hg.internal.Lifecycle; | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
32 import org.tmatesoft.hg.internal.Pool; | 
| 
264
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
33 import org.tmatesoft.hg.internal.Pool2; | 
| 
77
 
c677e1593919
Moved RevlogStream implementation into .internal
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
74 
diff
changeset
 | 
34 import org.tmatesoft.hg.internal.RevlogStream; | 
| 
232
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
35 import org.tmatesoft.hg.util.Path; | 
| 
74
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
36 | 
| 
2
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
37 | 
| 
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
38 /** | 
| 
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
39 * | 
| 
74
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
40 * @author Artem Tikhomirov | 
| 
 
6f1b88693d48
Complete refactoring to org.tmatesoft
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
28 
diff
changeset
 | 
41 * @author TMate Software Ltd. | 
| 
2
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
42 */ | 
| 
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
43 public class HgManifest extends Revlog { | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
44 private RevisionMapper revisionMap; | 
| 
2
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
45 | 
| 
13
 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
2 
diff
changeset
 | 
46 /*package-local*/ HgManifest(HgRepository hgRepo, RevlogStream content) { | 
| 
21
 
e929cecae4e1
Refactor to move revlog content to base class
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
20 
diff
changeset
 | 
47 super(hgRepo, content); | 
| 
13
 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
2 
diff
changeset
 | 
48 } | 
| 
 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
2 
diff
changeset
 | 
49 | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
50 /** | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
51 * | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
52 * @param start changelog (not manifest!) revision to begin with | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
53 * @param end changelog (not manifest!) revision to stop, inclusive. | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
54 * @param inspector can't be <code>null</code> | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
55 */ | 
| 
19
 
40532cdc92fc
Inspector (visitor) for manifest
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
16 
diff
changeset
 | 
56 public void walk(int start, int end, final Inspector inspector) { | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
57 if (inspector == null) { | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
58 throw new IllegalArgumentException(); | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
59 } | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
60 int start0 = fromChangelog(start); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
61 int end0 = fromChangelog(end); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
62 content.iterate(start0, end0, true, new ManifestParser(inspector)); | 
| 
19
 
40532cdc92fc
Inspector (visitor) for manifest
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
16 
diff
changeset
 | 
63 } | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
64 | 
| 
254
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
65 /** | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
66 * "Sparse" iteration of the manifest | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
67 * | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
68 * @param inspector | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
69 * @param localRevisions local changeset revisions to visit | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
70 */ | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
71 public void walk(final Inspector inspector, int... localRevisions) { | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
72 if (inspector == null || localRevisions == null) { | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
73 throw new IllegalArgumentException(); | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
74 } | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
75 int[] manifestLocalRevs = new int[localRevisions.length]; | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
76 boolean needsSort = false; | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
77 for (int i = 0; i < localRevisions.length; i++) { | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
78 final int manifestLocalRev = fromChangelog(localRevisions[i]); | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
79 manifestLocalRevs[i] = manifestLocalRev; | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
80 if (i > 0 && manifestLocalRevs[i-1] > manifestLocalRev) { | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
81 needsSort = true; | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
82 } | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
83 } | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
84 if (needsSort) { | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
85 Arrays.sort(manifestLocalRevs); | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
86 } | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
87 content.iterate(manifestLocalRevs, true, new ManifestParser(inspector)); | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
88 } | 
| 
 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
232 
diff
changeset
 | 
89 | 
| 
232
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
90 // manifest revision number that corresponds to the given changeset | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
91 /*package-local*/ int fromChangelog(int revisionNumber) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
92 if (HgInternals.wrongLocalRevision(revisionNumber)) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
93 throw new IllegalArgumentException(String.valueOf(revisionNumber)); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
94 } | 
| 
257
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
95 if (revisionNumber == HgRepository.WORKING_COPY || revisionNumber == HgRepository.BAD_REVISION) { | 
| 
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
96 throw new IllegalArgumentException("Can't use constants like WORKING_COPY or BAD_REVISION"); | 
| 
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
97 } | 
| 
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
98 // revisionNumber == TIP is processed by RevisionMapper | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
99 if (revisionMap == null) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
100 revisionMap = new RevisionMapper(getRepo()); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
101 content.iterate(0, TIP, false, revisionMap); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
102 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
103 return revisionMap.at(revisionNumber); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
104 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
105 | 
| 
232
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
106 /** | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
107 * Extracts file revision as it was known at the time of given changeset. | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
108 * | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
109 * @param revisionNumber local changeset index | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
110 * @param file path to file in question | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
111 * @return file revision or <code>null</code> if manifest at specified revision doesn't list such file | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
112 */ | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
113 @Experimental(reason="Perhaps, HgDataFile shall own this method") | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
114 public Nodeid getFileRevision(int revisionNumber, final Path file) { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
115 int rev = fromChangelog(revisionNumber); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
116 final Nodeid[] rv = new Nodeid[] { null }; | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
117 content.iterate(rev, rev, true, new RevlogStream.Inspector() { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
118 | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
119 public void next(int revisionNumber, int actualLen, int baseRevision, int linkRevision, int parent1Revision, int parent2Revision, byte[] nodeid, DataAccess data) { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
120 ByteArrayOutputStream bos = new ByteArrayOutputStream(); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
121 try { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
122 byte b; | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
123 while (!data.isEmpty() && (b = data.readByte()) != '\n') { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
124 if (b != 0) { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
125 bos.write(b); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
126 } else { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
127 String fname = new String(bos.toByteArray()); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
128 bos.reset(); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
129 if (file.toString().equals(fname)) { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
130 byte[] nid = new byte[40]; | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
131 data.readBytes(nid, 0, 40); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
132 rv[0] = Nodeid.fromAscii(nid, 0, 40); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
133 break; | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
134 } | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
135 // else skip to the end of line | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
136 while (!data.isEmpty() && (b = data.readByte()) != '\n') | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
137 ; | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
138 } | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
139 } | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
140 } catch (IOException ex) { | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
141 throw new HgBadStateException(ex); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
142 } | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
143 } | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
144 }); | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
145 return rv[0]; | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
146 } | 
| 
 
b7347daa50e3
Allow to cat a file with changeset revision
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
222 
diff
changeset
 | 
147 | 
| 
19
 
40532cdc92fc
Inspector (visitor) for manifest
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
16 
diff
changeset
 | 
148 public interface Inspector { | 
| 
222
 
373e07cd3991
Due to discrepancy in manifest and changelor indexes, wrong manifest revisions got cached and compared
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
220 
diff
changeset
 | 
149 boolean begin(int mainfestRevision, Nodeid nid, int changelogRevision); | 
| 
19
 
40532cdc92fc
Inspector (visitor) for manifest
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
16 
diff
changeset
 | 
150 boolean next(Nodeid nid, String fname, String flags); | 
| 
222
 
373e07cd3991
Due to discrepancy in manifest and changelor indexes, wrong manifest revisions got cached and compared
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
220 
diff
changeset
 | 
151 boolean end(int manifestRevision); | 
| 
2
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
152 } | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
153 | 
| 
266
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
154 private static class ManifestParser implements RevlogStream.Inspector/*, Lifecycle */{ | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
155 private boolean gtg = true; // good to go | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
156 private final Inspector inspector; | 
| 
264
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
157 private Pool2<Nodeid> nodeidPool, thisRevPool; | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
158 private final Pool2<String> fnamePool; | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
159 private final Pool<String> flagsPool; | 
| 
266
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
160 private final byte[] nodeidAsciiConvertBuffer = new byte[40]; | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
161 private byte[] nodeidLookupBuffer = new byte[20]; // get reassigned each time new Nodeid is added to pool | 
| 
262
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
162 | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
163 public ManifestParser(Inspector delegate) { | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
164 assert delegate != null; | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
165 inspector = delegate; | 
| 
264
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
166 nodeidPool = new Pool2<Nodeid>(); | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
167 fnamePool = new Pool2<String>(); | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
168 flagsPool = new Pool<String>(); | 
| 
264
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
169 thisRevPool = new Pool2<Nodeid>(); | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
170 } | 
| 
262
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
171 | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
172 public void next(int revisionNumber, int actualLen, int baseRevision, int linkRevision, int parent1Revision, int parent2Revision, byte[] nodeid, DataAccess da) { | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
173 if (!gtg) { | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
174 return; | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
175 } | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
176 try { | 
| 
222
 
373e07cd3991
Due to discrepancy in manifest and changelor indexes, wrong manifest revisions got cached and compared
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
220 
diff
changeset
 | 
177 gtg = gtg && inspector.begin(revisionNumber, new Nodeid(nodeid, true), linkRevision); | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
178 String fname = null; | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
179 String flags = null; | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
180 Nodeid nid = null; | 
| 
262
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
181 String data = new String(da.byteArray()); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
182 final int dataLen = data.length(); // due to byte->char conversion, may be different | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
183 for (int x = 0; gtg && x < dataLen; x++) { | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
184 int start = x; | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
185 x = data.indexOf('\n', x+1); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
186 assert x != -1; | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
187 int z = data.indexOf('\0', start+1); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
188 assert z!= -1; | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
189 assert z < x; | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
190 fname = data.substring(start, z); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
191 if (fnamePool.contains(fname)) { | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
192 fname = fnamePool.unify(fname); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
193 } else { | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
194 fnamePool.record(fname = new String(fname)); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
195 } | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
196 z++; // cursor at first char of nodeid | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
197 int nodeidLen = x-z < 40 ? x-z : 40; // if x-z > 40, there are flags | 
| 
266
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
198 for (int k = 0; k < nodeidLen; k++) { | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
199 // intentionally didn't clear array as it shall be of length 40 (Nodeid.fromAscii won't stand anything but 40) | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
200 nodeidAsciiConvertBuffer[k] = (byte) data.charAt(z+k); | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
201 } | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
202 DigestHelper.ascii2bin(nodeidAsciiConvertBuffer, 0, nodeidLen, nodeidLookupBuffer); | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
203 nid = new Nodeid(nodeidLookupBuffer, false); // this Nodeid is for pool lookup only, mock object | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
204 Nodeid cached = nodeidPool.unify(nid); | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
205 if (cached == nid) { | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
206 // buffer now belongs to the cached nodeid | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
207 nodeidLookupBuffer = new byte[20]; | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
208 } else { | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
209 nid = cached; // use existing version, discard the lookup object | 
| 
 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
264 
diff
changeset
 | 
210 } | 
| 
262
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
211 thisRevPool.record(nid); // memorize revision for the next iteration. | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
212 if (x-z > 40) { | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
213 // 'x' and 'l' for executable bits and symlinks? | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
214 // hg --debug manifest shows 644 for each regular file in my repo | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
215 // for cpython repo, there are 755 in hg --debug output when 'x' flag is present | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
216 flags = data.substring(z + nodeidLen, x); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
217 if (flagsPool.contains(flags)) { | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
218 flags = flagsPool.unify(flags); | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
219 } else { | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
220 flagsPool.record(flags = new String(flags)); | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
221 } | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
222 } | 
| 
262
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
223 gtg = gtg && inspector.next(nid, fname, flags); | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
224 nid = null; | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
225 fname = flags = null; | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
226 } | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
227 gtg = gtg && inspector.end(revisionNumber); | 
| 
262
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
228 // | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
229 // keep only actual file revisions, found at this version | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
230 // (next manifest is likely to refer to most of them, although in specific cases | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
231 // like commit in another branch a lot may be useless) | 
| 
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
232 nodeidPool.clear(); | 
| 
264
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
233 Pool2<Nodeid> t = nodeidPool; | 
| 
262
 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
257 
diff
changeset
 | 
234 nodeidPool = thisRevPool; | 
| 
264
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
235 thisRevPool = t; | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
236 } catch (IOException ex) { | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
237 throw new HgBadStateException(ex); | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
238 } | 
| 
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
239 } | 
| 
264
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
240 // | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
241 // public void start(int count, Callback callback, Object token) { | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
242 // } | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
243 // | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
244 // public void finish(Object token) { | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
245 // System.out.println(fnamePool); | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
246 // System.out.println(nodeidPool); | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
247 // System.out.printf("Free mem once parse done: %,d\n", Runtime.getRuntime().freeMemory()); | 
| 
 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
262 
diff
changeset
 | 
248 // } | 
| 
196
 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
157 
diff
changeset
 | 
249 } | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
250 | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
251 private static class RevisionMapper implements RevlogStream.Inspector, Lifecycle { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
252 | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
253 private final int changelogRevisions; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
254 private int[] changelog2manifest; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
255 private final HgRepository repo; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
256 | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
257 public RevisionMapper(HgRepository hgRepo) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
258 repo = hgRepo; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
259 changelogRevisions = repo.getChangelog().getRevisionCount(); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
260 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
261 | 
| 
257
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
262 // respects TIP | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
263 public int at(int revisionNumber) { | 
| 
257
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
264 if (revisionNumber == TIP) { | 
| 
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
265 revisionNumber = changelogRevisions - 1; | 
| 
 
f39fb6b3cc76
Handle revision constants correctly
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
254 
diff
changeset
 | 
266 } | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
267 if (changelog2manifest != null) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
268 return changelog2manifest[revisionNumber]; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
269 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
270 return revisionNumber; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
271 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
272 | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
273 public void next(int revisionNumber, int actualLen, int baseRevision, int linkRevision, int parent1Revision, int parent2Revision, byte[] nodeid, DataAccess data) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
274 if (changelog2manifest != null) { | 
| 
220
 
8de327242aa0
Basic information about branches
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
218 
diff
changeset
 | 
275 // next assertion is not an error, rather assumption check, which is too development-related to be explicit exception - | 
| 
 
8de327242aa0
Basic information about branches
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
218 
diff
changeset
 | 
276 // I just wonder if there are manifests that have two entries pointing to single changeset. It seems unrealistic, though - | 
| 
 
8de327242aa0
Basic information about branches
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
218 
diff
changeset
 | 
277 // changeset records one and only one manifest nodeid | 
| 
 
8de327242aa0
Basic information about branches
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
218 
diff
changeset
 | 
278 assert changelog2manifest[linkRevision] == -1 : String.format("revision:%d, link:%d, already linked to revision:%d", revisionNumber, linkRevision, changelog2manifest[linkRevision]); | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
279 changelog2manifest[linkRevision] = revisionNumber; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
280 } else { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
281 if (revisionNumber != linkRevision) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
282 changelog2manifest = new int[changelogRevisions]; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
283 Arrays.fill(changelog2manifest, -1); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
284 for (int i = 0; i < revisionNumber; changelog2manifest[i] = i, i++) | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
285 ; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
286 changelog2manifest[linkRevision] = revisionNumber; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
287 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
288 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
289 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
290 | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
291 public void start(int count, Callback callback, Object token) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
292 if (count != changelogRevisions) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
293 assert count < changelogRevisions; // no idea what to do if manifest has more revisions than changelog | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
294 // the way how manifest may contain more revisions than changelog, as I can imagine, is a result of | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
295 // some kind of an import tool (e.g. from SVN or CVS), that creates manifest and changelog independently. | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
296 // Note, it's pure guess, I didn't see such repository yet (although the way manifest revisions | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
297 // in cpython repo are numbered makes me think aforementioned way) | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
298 changelog2manifest = new int[changelogRevisions]; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
299 Arrays.fill(changelog2manifest, -1); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
300 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
301 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
302 | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
303 public void finish(Object token) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
304 if (changelog2manifest == null) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
305 return; | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
306 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
307 // I assume there'd be not too many revisions we don't know manifest of | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
308 ArrayList<Integer> undefinedChangelogRevision = new ArrayList<Integer>(); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
309 for (int i = 0; i < changelog2manifest.length; i++) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
310 if (changelog2manifest[i] == -1) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
311 undefinedChangelogRevision.add(i); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
312 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
313 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
314 for (int u : undefinedChangelogRevision) { | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
315 Nodeid manifest = repo.getChangelog().range(u, u).get(0).manifest(); | 
| 
220
 
8de327242aa0
Basic information about branches
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
218 
diff
changeset
 | 
316 // FIXME calculate those missing effectively (e.g. cache and sort nodeids to speed lookup | 
| 
218
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
317 // right away in the #next (may refactor ParentWalker's sequential and sorted into dedicated helper and reuse here) | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
318 changelog2manifest[u] = repo.getManifest().getLocalRevision(manifest); | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
319 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
320 } | 
| 
 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents: 
196 
diff
changeset
 | 
321 } | 
| 
2
 
08db726a0fb7
Shaping out low-level Hg structures
 
Artem Tikhomirov <tikhomirov.artem@gmail.com> 
parents:  
diff
changeset
 | 
322 } | 
