Mercurial > hg4j
annotate src/org/tmatesoft/hg/repo/HgManifest.java @ 332:72c6eda838a6
NPE in HgDirstate.known() when no dirstate file present
| author | Artem Tikhomirov <tikhomirov.artem@gmail.com> | 
|---|---|
| date | Wed, 09 Nov 2011 04:33:44 +0100 | 
| parents | d42a45a2c9d6 | 
| children | 5f9073eabf06 | 
| rev | line source | 
|---|---|
| 13 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
2diff
changeset | 1 /* | 
| 74 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 2 * Copyright (c) 2010-2011 TMate Software Ltd | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 3 * | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 4 * This program is free software; you can redistribute it and/or modify | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 5 * it under the terms of the GNU General Public License as published by | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 6 * the Free Software Foundation; version 2 of the License. | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 7 * | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 8 * This program is distributed in the hope that it will be useful, | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 9 * but WITHOUT ANY WARRANTY; without even the implied warranty of | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 10 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 11 * GNU General Public License for more details. | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 12 * | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 13 * For information on how to redistribute this software under | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 14 * the terms of a license other than GNU General Public License | 
| 102 
a3a2e5deb320
Updated contact address to support@hg4j.com
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
77diff
changeset | 15 * contact TMate Software at support@hg4j.com | 
| 2 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 16 */ | 
| 74 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 17 package org.tmatesoft.hg.repo; | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 18 | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 19 import static org.tmatesoft.hg.repo.HgRepository.TIP; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 20 | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 21 import java.io.ByteArrayOutputStream; | 
| 157 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 Artem Tikhomirov <tikhomirov.artem@gmail.com>diff
changeset | 22 import java.io.IOException; | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 23 import java.util.ArrayList; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 24 import java.util.Arrays; | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 25 import java.util.HashMap; | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 26 import java.util.Map; | 
| 157 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 Artem Tikhomirov <tikhomirov.artem@gmail.com>diff
changeset | 27 | 
| 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 Artem Tikhomirov <tikhomirov.artem@gmail.com>diff
changeset | 28 import org.tmatesoft.hg.core.HgBadStateException; | 
| 74 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 29 import org.tmatesoft.hg.core.Nodeid; | 
| 157 
d5268ca7715b
Merged branch wrap-data-access into default for resource-friendly data access. Updated API to promote that friendliness to clients (channels, not byte[]). More exceptions
 Artem Tikhomirov <tikhomirov.artem@gmail.com>diff
changeset | 30 import org.tmatesoft.hg.internal.DataAccess; | 
| 266 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
264diff
changeset | 31 import org.tmatesoft.hg.internal.DigestHelper; | 
| 320 
678e326fd27c
Issue 15: Exception accessing oddly named file from history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
313diff
changeset | 32 import org.tmatesoft.hg.internal.EncodingHelper; | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 33 import org.tmatesoft.hg.internal.Experimental; | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 34 import org.tmatesoft.hg.internal.IterateControlMediator; | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 35 import org.tmatesoft.hg.internal.Lifecycle; | 
| 304 
85b8efde5586
Use memory-friendly set implementation to canonicalize filenames and nodeids
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
300diff
changeset | 36 import org.tmatesoft.hg.internal.Pool2; | 
| 77 
c677e1593919
Moved RevlogStream implementation into .internal
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
74diff
changeset | 37 import org.tmatesoft.hg.internal.RevlogStream; | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 38 import org.tmatesoft.hg.util.CancelSupport; | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 39 import org.tmatesoft.hg.util.Path; | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 40 import org.tmatesoft.hg.util.ProgressSupport; | 
| 74 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 41 | 
| 2 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 42 | 
| 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 43 /** | 
| 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 44 * | 
| 74 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 45 * @author Artem Tikhomirov | 
| 
6f1b88693d48
Complete refactoring to org.tmatesoft
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
28diff
changeset | 46 * @author TMate Software Ltd. | 
| 2 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 47 */ | 
| 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 48 public class HgManifest extends Revlog { | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 49 private RevisionMapper revisionMap; | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 50 | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 51 public enum Flags { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 52 Exec, Link; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 53 | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 54 static Flags parse(String flags) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 55 if ("x".equalsIgnoreCase(flags)) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 56 return Exec; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 57 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 58 if ("l".equalsIgnoreCase(flags)) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 59 return Link; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 60 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 61 if (flags == null) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 62 return null; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 63 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 64 throw new IllegalStateException(flags); | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 65 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 66 | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 67 static Flags parse(byte[] data, int start, int length) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 68 if (length == 0) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 69 return null; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 70 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 71 if (length == 1) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 72 if (data[start] == 'x') { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 73 return Exec; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 74 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 75 if (data[start] == 'l') { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 76 return Link; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 77 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 78 // FALL THROUGH | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 79 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 80 throw new IllegalStateException(new String(data, start, length)); | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 81 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 82 | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 83 String nativeString() { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 84 if (this == Exec) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 85 return "x"; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 86 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 87 if (this == Link) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 88 return "l"; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 89 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 90 throw new IllegalStateException(toString()); | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 91 } | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 92 } | 
| 2 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 93 | 
| 13 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
2diff
changeset | 94 /*package-local*/ HgManifest(HgRepository hgRepo, RevlogStream content) { | 
| 21 
e929cecae4e1
Refactor to move revlog content to base class
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
20diff
changeset | 95 super(hgRepo, content); | 
| 13 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
2diff
changeset | 96 } | 
| 
df8c67f3006a
Basic manifest parsing to analyze what's in there
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
2diff
changeset | 97 | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 98 /** | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 99 * | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 100 * @param start changelog (not manifest!) revision to begin with | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 101 * @param end changelog (not manifest!) revision to stop, inclusive. | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 102 * @param inspector can't be <code>null</code> | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 103 */ | 
| 19 
40532cdc92fc
Inspector (visitor) for manifest
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
16diff
changeset | 104 public void walk(int start, int end, final Inspector inspector) { | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 105 if (inspector == null) { | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 106 throw new IllegalArgumentException(); | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 107 } | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 108 int start0 = fromChangelog(start); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 109 int end0 = fromChangelog(end); | 
| 300 
650b45d290b1
Share range check code
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
285diff
changeset | 110 if (end0 < start0) { | 
| 
650b45d290b1
Share range check code
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
285diff
changeset | 111 // there are tool-constructed repositories that got order of changeset revisions completely different from that of manifest | 
| 
650b45d290b1
Share range check code
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
285diff
changeset | 112 int x = end0; | 
| 
650b45d290b1
Share range check code
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
285diff
changeset | 113 end0 = start0; | 
| 
650b45d290b1
Share range check code
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
285diff
changeset | 114 start0 = x; | 
| 
650b45d290b1
Share range check code
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
285diff
changeset | 115 } | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 116 content.iterate(start0, end0, true, new ManifestParser(inspector)); | 
| 19 
40532cdc92fc
Inspector (visitor) for manifest
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
16diff
changeset | 117 } | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 118 | 
| 254 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 119 /** | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 120 * "Sparse" iteration of the manifest | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 121 * | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 122 * @param inspector | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 123 * @param localRevisions local changeset revisions to visit | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 124 */ | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 125 public void walk(final Inspector inspector, int... localRevisions) { | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 126 if (inspector == null || localRevisions == null) { | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 127 throw new IllegalArgumentException(); | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 128 } | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 129 int[] localManifestRevs = toLocalManifestRevisions(localRevisions); | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 130 content.iterate(localManifestRevs, true, new ManifestParser(inspector)); | 
| 254 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 131 } | 
| 
a620f0663a37
Collect tags for a file - improve performance of 'sparse' manifest reads
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
232diff
changeset | 132 | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 133 // manifest revision number that corresponds to the given changeset | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 134 /*package-local*/ int fromChangelog(int revisionNumber) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 135 if (HgInternals.wrongLocalRevision(revisionNumber)) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 136 throw new IllegalArgumentException(String.valueOf(revisionNumber)); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 137 } | 
| 257 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 138 if (revisionNumber == HgRepository.WORKING_COPY || revisionNumber == HgRepository.BAD_REVISION) { | 
| 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 139 throw new IllegalArgumentException("Can't use constants like WORKING_COPY or BAD_REVISION"); | 
| 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 140 } | 
| 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 141 // revisionNumber == TIP is processed by RevisionMapper | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 142 if (revisionMap == null) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 143 revisionMap = new RevisionMapper(getRepo()); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 144 content.iterate(0, TIP, false, revisionMap); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 145 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 146 return revisionMap.at(revisionNumber); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 147 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 148 | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 149 /** | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 150 * Extracts file revision as it was known at the time of given changeset. | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 151 * | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 152 * @param localChangelogRevision local changeset index | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 153 * @param file path to file in question | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 154 * @return file revision or <code>null</code> if manifest at specified revision doesn't list such file | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 155 */ | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 156 @Experimental(reason="Perhaps, HgDataFile shall own this method, or get a delegate?") | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 157 public Nodeid getFileRevision(int localChangelogRevision, final Path file) { | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 158 return getFileRevisions(file, localChangelogRevision).get(localChangelogRevision); | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 159 } | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 160 | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 161 // XXX package-local, IntMap, and HgDataFile getFileRevisionAt(int... localChangelogRevisions) | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 162 @Experimental(reason="@see #getFileRevision") | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 163 public Map<Integer, Nodeid> getFileRevisions(final Path file, int... localChangelogRevisions) { | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 164 // FIXME need tests | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 165 int[] localManifestRevisions = toLocalManifestRevisions(localChangelogRevisions); | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 166 final HashMap<Integer,Nodeid> rv = new HashMap<Integer, Nodeid>(localChangelogRevisions.length); | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 167 content.iterate(localManifestRevisions, true, new RevlogStream.Inspector() { | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 168 | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 169 public void next(int revisionNumber, int actualLen, int baseRevision, int linkRevision, int parent1Revision, int parent2Revision, byte[] nodeid, DataAccess data) { | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 170 ByteArrayOutputStream bos = new ByteArrayOutputStream(); | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 171 try { | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 172 byte b; | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 173 while (!data.isEmpty() && (b = data.readByte()) != '\n') { | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 174 if (b != 0) { | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 175 bos.write(b); | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 176 } else { | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 177 String fname = new String(bos.toByteArray()); | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 178 bos.reset(); | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 179 if (file.toString().equals(fname)) { | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 180 byte[] nid = new byte[40]; | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 181 data.readBytes(nid, 0, 40); | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 182 rv.put(linkRevision, Nodeid.fromAscii(nid, 0, 40)); | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 183 break; | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 184 } else { | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 185 data.skip(40); | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 186 } | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 187 // else skip to the end of line | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 188 while (!data.isEmpty() && (b = data.readByte()) != '\n') | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 189 ; | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 190 } | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 191 } | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 192 } catch (IOException ex) { | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 193 throw new HgBadStateException(ex); | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 194 } | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 195 } | 
| 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 196 }); | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 197 return rv; | 
| 232 
b7347daa50e3
Allow to cat a file with changeset revision
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
222diff
changeset | 198 } | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 199 | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 200 | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 201 private int[] toLocalManifestRevisions(int[] localChangelogRevisions) { | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 202 int[] localManifestRevs = new int[localChangelogRevisions.length]; | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 203 boolean needsSort = false; | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 204 for (int i = 0; i < localChangelogRevisions.length; i++) { | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 205 final int manifestLocalRev = fromChangelog(localChangelogRevisions[i]); | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 206 localManifestRevs[i] = manifestLocalRev; | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 207 if (i > 0 && localManifestRevs[i-1] > manifestLocalRev) { | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 208 needsSort = true; | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 209 } | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 210 } | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 211 if (needsSort) { | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 212 Arrays.sort(localManifestRevs); | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 213 } | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 214 return localManifestRevs; | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 215 } | 
| 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 216 | 
| 19 
40532cdc92fc
Inspector (visitor) for manifest
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
16diff
changeset | 217 public interface Inspector { | 
| 222 
373e07cd3991
Due to discrepancy in manifest and changelor indexes, wrong manifest revisions got cached and compared
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
220diff
changeset | 218 boolean begin(int mainfestRevision, Nodeid nid, int changelogRevision); | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 219 /** | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 220 * @deprecated switch to {@link Inspector2#next(Nodeid, Path, Flags)} | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 221 */ | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 222 @Deprecated | 
| 19 
40532cdc92fc
Inspector (visitor) for manifest
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
16diff
changeset | 223 boolean next(Nodeid nid, String fname, String flags); | 
| 222 
373e07cd3991
Due to discrepancy in manifest and changelor indexes, wrong manifest revisions got cached and compared
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
220diff
changeset | 224 boolean end(int manifestRevision); | 
| 2 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 225 } | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 226 | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 227 @Experimental(reason="Explore Path alternative for filenames and enum for flags") | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 228 public interface Inspector2 extends Inspector { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 229 boolean next(Nodeid nid, Path fname, Flags flags); | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 230 } | 
| 326 
d42a45a2c9d6
Alternative tag collection approach for a file history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
324diff
changeset | 231 | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 232 /** | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 233 * When Pool uses Strings directly, | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 234 * ManifestParser creates new String instance with new char[] value, and does byte->char conversion. | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 235 * For cpython repo, walk(0..10k), there are over 16 million filenames, of them only 3020 unique. | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 236 * This means there are 15.9 million useless char[] instances and byte->char conversions | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 237 * | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 238 * When String (Path) is wrapped into {@link PathProxy}, there's extra overhead of byte[] representation | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 239 * of the String, but these are only for unique Strings (Paths) (3020 in the example above). Besides, I save | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 240 * useless char[] and byte->char conversions. | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 241 */ | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 242 private static class PathProxy { | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 243 private byte[] data; | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 244 private int start; | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 245 private final int hash, length; | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 246 private Path result; | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 247 | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 248 public PathProxy(byte[] data, int start, int length) { | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 249 this.data = data; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 250 this.start = start; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 251 this.length = length; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 252 | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 253 // copy from String.hashCode(). In fact, not necessarily match result of String(data).hashCode | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 254 // just need some nice algorithm here | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 255 int h = 0; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 256 byte[] d = data; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 257 for (int i = 0, off = start, len = length; i < len; i++) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 258 h = 31 * h + d[off++]; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 259 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 260 hash = h; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 261 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 262 | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 263 @Override | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 264 public boolean equals(Object obj) { | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 265 if (false == obj instanceof PathProxy) { | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 266 return false; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 267 } | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 268 PathProxy o = (PathProxy) obj; | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 269 if (o.result != null && result != null) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 270 return result.equals(o.result); | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 271 } | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 272 if (o.length != length || o.hash != hash) { | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 273 return false; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 274 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 275 for (int i = 0, x = o.start, y = start; i < length; i++) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 276 if (o.data[x++] != data[y++]) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 277 return false; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 278 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 279 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 280 return true; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 281 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 282 @Override | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 283 public int hashCode() { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 284 return hash; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 285 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 286 | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 287 public Path freeze() { | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 288 if (result == null) { | 
| 320 
678e326fd27c
Issue 15: Exception accessing oddly named file from history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
313diff
changeset | 289 result = Path.create(EncodingHelper.fromManifest(data, start, length)); | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 290 // release reference to bigger data array, make a copy of relevant part only | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 291 // use original bytes, not those from String above to avoid cache misses due to different encodings | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 292 byte[] d = new byte[length]; | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 293 System.arraycopy(data, start, d, 0, length); | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 294 data = d; | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 295 start = 0; | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 296 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 297 return result; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 298 } | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 299 } | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 300 | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 301 private static class ManifestParser implements RevlogStream.Inspector, Lifecycle { | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 302 private final Inspector inspector; | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 303 private final Inspector2 inspector2; | 
| 304 
85b8efde5586
Use memory-friendly set implementation to canonicalize filenames and nodeids
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
300diff
changeset | 304 private Pool2<Nodeid> nodeidPool, thisRevPool; | 
| 
85b8efde5586
Use memory-friendly set implementation to canonicalize filenames and nodeids
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
300diff
changeset | 305 private final Pool2<PathProxy> fnamePool; | 
| 266 
0a2f445de774
Improve manifest parsing: reduce number of arrays instantiated for Nodeid
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
264diff
changeset | 306 private byte[] nodeidLookupBuffer = new byte[20]; // get reassigned each time new Nodeid is added to pool | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 307 private final ProgressSupport progressHelper; | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 308 private IterateControlMediator iterateControl; | 
| 262 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
257diff
changeset | 309 | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 310 public ManifestParser(Inspector delegate) { | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 311 assert delegate != null; | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 312 inspector = delegate; | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 313 inspector2 = delegate instanceof Inspector2 ? (Inspector2) delegate : null; | 
| 304 
85b8efde5586
Use memory-friendly set implementation to canonicalize filenames and nodeids
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
300diff
changeset | 314 nodeidPool = new Pool2<Nodeid>(); | 
| 
85b8efde5586
Use memory-friendly set implementation to canonicalize filenames and nodeids
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
300diff
changeset | 315 fnamePool = new Pool2<PathProxy>(); | 
| 
85b8efde5586
Use memory-friendly set implementation to canonicalize filenames and nodeids
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
300diff
changeset | 316 thisRevPool = new Pool2<Nodeid>(); | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 317 progressHelper = ProgressSupport.Factory.get(delegate); | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 318 } | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 319 | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 320 public void next(int revisionNumber, int actualLen, int baseRevision, int linkRevision, int parent1Revision, int parent2Revision, byte[] nodeid, DataAccess da) { | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 321 try { | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 322 if (!inspector.begin(revisionNumber, new Nodeid(nodeid, true), linkRevision)) { | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 323 iterateControl.stop(); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 324 return; | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 325 } | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 326 Path fname = null; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 327 Flags flags = null; | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 328 Nodeid nid = null; | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 329 int i; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 330 byte[] data = da.byteArray(); | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 331 for (i = 0; i < actualLen; i++) { | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 332 int x = i; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 333 for( ; data[i] != '\n' && i < actualLen; i++) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 334 if (fname == null && data[i] == 0) { | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 335 PathProxy px = fnamePool.unify(new PathProxy(data, x, i - x)); | 
| 268 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 336 // if (cached = fnamePool.unify(px))== px then cacheMiss, else cacheHit | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 337 // cpython 0..10k: hits: 15 989 152, misses: 3020 | 
| 
c5980f287cc4
Use StringProxy when parsing manifest to minimize number of useless conversions and array instances
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
267diff
changeset | 338 fname = px.freeze(); | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 339 x = i+1; | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 340 } | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 341 } | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 342 if (i < actualLen) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 343 assert data[i] == '\n'; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 344 int nodeidLen = i - x < 40 ? i-x : 40; // if > 40, there are flags | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 345 DigestHelper.ascii2bin(data, x, nodeidLen, nodeidLookupBuffer); // ignore return value as it's unlikely to have NULL in manifest | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 346 nid = new Nodeid(nodeidLookupBuffer, false); // this Nodeid is for pool lookup only, mock object | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 347 Nodeid cached = nodeidPool.unify(nid); | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 348 if (cached == nid) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 349 // buffer now belongs to the cached nodeid | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 350 nodeidLookupBuffer = new byte[20]; | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 351 } else { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 352 nid = cached; // use existing version, discard the lookup object | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 353 } // for cpython 0..10k, cache hits are 15 973 301, vs 18871 misses. | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 354 thisRevPool.record(nid); // memorize revision for the next iteration. | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 355 if (nodeidLen + x < i) { | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 356 // 'x' and 'l' for executable bits and symlinks? | 
| 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 357 // hg --debug manifest shows 644 for each regular file in my repo | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 358 // for cpython 0..10k, there are 4361062 flag checks, and there's only 1 unique flag | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 359 flags = Flags.parse(data, x + nodeidLen, i-x-nodeidLen); | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 360 } else { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 361 flags = null; | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 362 } | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 363 boolean good2go; | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 364 if (inspector2 == null) { | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 365 String flagString = flags == null ? null : flags.nativeString(); | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 366 good2go = inspector.next(nid, fname.toString(), flagString); | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 367 } else { | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 368 good2go = inspector2.next(nid, fname, flags); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 369 } | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 370 if (!good2go) { | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 371 iterateControl.stop(); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 372 return; | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 373 } | 
| 267 
ec921ef0628e
Revert manifest parser changes - no single string and back to HashMap Pool
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
266diff
changeset | 374 } | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 375 nid = null; | 
| 285 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 376 fname = null; | 
| 
6dbbc53fc46d
Use Path instead of plain String for manifest file names
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
268diff
changeset | 377 flags = null; | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 378 } | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 379 if (!inspector.end(revisionNumber)) { | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 380 iterateControl.stop(); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 381 return; | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 382 } | 
| 262 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
257diff
changeset | 383 // | 
| 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
257diff
changeset | 384 // keep only actual file revisions, found at this version | 
| 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
257diff
changeset | 385 // (next manifest is likely to refer to most of them, although in specific cases | 
| 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
257diff
changeset | 386 // like commit in another branch a lot may be useless) | 
| 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
257diff
changeset | 387 nodeidPool.clear(); | 
| 304 
85b8efde5586
Use memory-friendly set implementation to canonicalize filenames and nodeids
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
300diff
changeset | 388 Pool2<Nodeid> t = nodeidPool; | 
| 262 
3dcd3dd90c77
Improve manifest parsing: decode bytes to chars once, minimize arraycopy on String instantiation, keep set of file revisions from previous manifest only
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
257diff
changeset | 389 nodeidPool = thisRevPool; | 
| 264 
6bb5e7ed051a
Optimize memory usage (reduce number of objects instantiated) when pooling file names and nodeids during manifest parsing
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
262diff
changeset | 390 thisRevPool = t; | 
| 313 
c1e3c18fd2f2
Test manifest cancellation
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
312diff
changeset | 391 iterateControl.checkCancelled(); | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 392 progressHelper.worked(1); | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 393 } catch (IOException ex) { | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 394 throw new HgBadStateException(ex); | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 395 } | 
| 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 396 } | 
| 312 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 397 | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 398 public void start(int count, Callback callback, Object token) { | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 399 CancelSupport cs = CancelSupport.Factory.get(inspector, null); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 400 iterateControl = new IterateControlMediator(cs, callback); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 401 progressHelper.start(count); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 402 } | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 403 | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 404 public void finish(Object token) { | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 405 progressHelper.done(); | 
| 
f9f3e9b67ccc
Facilitate cancellation and progress reporting in changelog and manifest iterations
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
304diff
changeset | 406 } | 
| 196 
e2115da4cf6a
Pool objects to avoid memory polution with duplicates
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
157diff
changeset | 407 } | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 408 | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 409 private static class RevisionMapper implements RevlogStream.Inspector, Lifecycle { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 410 | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 411 private final int changelogRevisions; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 412 private int[] changelog2manifest; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 413 private final HgRepository repo; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 414 | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 415 public RevisionMapper(HgRepository hgRepo) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 416 repo = hgRepo; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 417 changelogRevisions = repo.getChangelog().getRevisionCount(); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 418 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 419 | 
| 257 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 420 // respects TIP | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 421 public int at(int revisionNumber) { | 
| 257 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 422 if (revisionNumber == TIP) { | 
| 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 423 revisionNumber = changelogRevisions - 1; | 
| 
f39fb6b3cc76
Handle revision constants correctly
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
254diff
changeset | 424 } | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 425 if (changelog2manifest != null) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 426 return changelog2manifest[revisionNumber]; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 427 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 428 return revisionNumber; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 429 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 430 | 
| 324 
283b294d1079
Explore alternatives to access file-changelog combined history
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
321diff
changeset | 431 // XXX likely can be replaced with Revlog.RevisionInspector | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 432 public void next(int revisionNumber, int actualLen, int baseRevision, int linkRevision, int parent1Revision, int parent2Revision, byte[] nodeid, DataAccess data) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 433 if (changelog2manifest != null) { | 
| 220 
8de327242aa0
Basic information about branches
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
218diff
changeset | 434 // next assertion is not an error, rather assumption check, which is too development-related to be explicit exception - | 
| 
8de327242aa0
Basic information about branches
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
218diff
changeset | 435 // I just wonder if there are manifests that have two entries pointing to single changeset. It seems unrealistic, though - | 
| 
8de327242aa0
Basic information about branches
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
218diff
changeset | 436 // changeset records one and only one manifest nodeid | 
| 
8de327242aa0
Basic information about branches
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
218diff
changeset | 437 assert changelog2manifest[linkRevision] == -1 : String.format("revision:%d, link:%d, already linked to revision:%d", revisionNumber, linkRevision, changelog2manifest[linkRevision]); | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 438 changelog2manifest[linkRevision] = revisionNumber; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 439 } else { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 440 if (revisionNumber != linkRevision) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 441 changelog2manifest = new int[changelogRevisions]; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 442 Arrays.fill(changelog2manifest, -1); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 443 for (int i = 0; i < revisionNumber; changelog2manifest[i] = i, i++) | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 444 ; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 445 changelog2manifest[linkRevision] = revisionNumber; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 446 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 447 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 448 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 449 | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 450 public void start(int count, Callback callback, Object token) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 451 if (count != changelogRevisions) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 452 assert count < changelogRevisions; // no idea what to do if manifest has more revisions than changelog | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 453 // the way how manifest may contain more revisions than changelog, as I can imagine, is a result of | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 454 // some kind of an import tool (e.g. from SVN or CVS), that creates manifest and changelog independently. | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 455 // Note, it's pure guess, I didn't see such repository yet (although the way manifest revisions | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 456 // in cpython repo are numbered makes me think aforementioned way) | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 457 changelog2manifest = new int[changelogRevisions]; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 458 Arrays.fill(changelog2manifest, -1); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 459 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 460 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 461 | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 462 public void finish(Object token) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 463 if (changelog2manifest == null) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 464 return; | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 465 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 466 // I assume there'd be not too many revisions we don't know manifest of | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 467 ArrayList<Integer> undefinedChangelogRevision = new ArrayList<Integer>(); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 468 for (int i = 0; i < changelog2manifest.length; i++) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 469 if (changelog2manifest[i] == -1) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 470 undefinedChangelogRevision.add(i); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 471 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 472 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 473 for (int u : undefinedChangelogRevision) { | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 474 Nodeid manifest = repo.getChangelog().range(u, u).get(0).manifest(); | 
| 220 
8de327242aa0
Basic information about branches
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
218diff
changeset | 475 // FIXME calculate those missing effectively (e.g. cache and sort nodeids to speed lookup | 
| 218 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 476 // right away in the #next (may refactor ParentWalker's sequential and sorted into dedicated helper and reuse here) | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 477 changelog2manifest[u] = repo.getManifest().getLocalRevision(manifest); | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 478 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 479 } | 
| 
047b1dec7a04
Issue 7: Correctly handle manifest and changelog with different number of (or non-matching) revisions
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: 
196diff
changeset | 480 } | 
| 2 
08db726a0fb7
Shaping out low-level Hg structures
 Artem Tikhomirov <tikhomirov.artem@gmail.com> parents: diff
changeset | 481 } | 
